Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added missing Google Cloud Storage extension in extensions/README.md #3085 #3089

Merged
merged 1 commit into from
May 30, 2023

Conversation

syedinay
Copy link
Contributor

#3085

What this PR changes/adds

The documentation was missing the Google Cloud Storage extension in the data pane section. This PR adds the missing extension.

Why it does that

NA

Further notes

NA

Linked Issue(s)

#3085

Closes 1

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please sign the ECA and fix the title according to the "pull requests etiquette" so we can merge this 👍

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label May 25, 2023
@syedinay syedinay changed the title Added missing Google Cloud Storage extension in README.md Google Cloud Storage extension is missing in extensions/README.md #3085 May 25, 2023
@syedinay
Copy link
Contributor Author

Hello @ndr-brt please let me know if the title is correct now. I am facing issues in creating a eclipse foundation account, once that is sorted I will be signing the ECA.
Thank you

@ndr-brt
Copy link
Member

ndr-brt commented May 26, 2023

Hello @ndr-brt please let me know if the title is correct now. I am facing issues in creating a eclipse foundation account, once that is sorted I will be signing the ECA. Thank you

Both title and eca checks are still failing, you can check them out to see what's wrong

@syedinay syedinay changed the title Google Cloud Storage extension is missing in extensions/README.md #3085 docs: Added missing Google Cloud Storage extension in extensions/README.md #3085 May 29, 2023
@ndr-brt ndr-brt merged commit 62d2ae9 into eclipse-edc:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants